mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 47400: Documentation quota authorization changes in 0.29.
Date Tue, 17 May 2016 20:36:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133622
-----------------------------------------------------------



Looks good to me. I'll commit https://reviews.apache.org/r/46501/ first (tomorrow), will ask
you to rebase this and do a final pass afterwards. Thanks for the great job!


docs/authorization.md (line 359)
<https://reviews.apache.org/r/47400/#comment198163>

    s/retrive/query x2
    s/retrieve/query



docs/quota.md (line 159)
<https://reviews.apache.org/r/47400/#comment198164>

    s/retrieve/query



docs/quota.md (line 189)
<https://reviews.apache.org/r/47400/#comment198165>

    s/retrieve/query



docs/upgrades.md (line 169)
<https://reviews.apache.org/r/47400/#comment198166>

    Let's mention `UPDATE_QUOTA_WITH_ROLE` as a substitute for deprecated actions. Also, please
mentions authz actions first and ACLs second, since the latter are only for local authorizer.


- Alexander Rukletsov


On May 17, 2016, 7:15 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
>     https://issues.apache.org/jira/browse/MESOS-5155
>     https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 825366d771f3b1bf26cec2ec1cb87619e82f9c8f 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message