mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 47400: Documentation quota authorization changes in 0.29.
Date Tue, 17 May 2016 17:58:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133579
-----------------------------------------------------------



Please be advised that if https://reviews.apache.org/r/46501/ lands before, you'll have to
rebase this patch on top.


docs/authorization.md (line 13)
<https://reviews.apache.org/r/47400/#comment198095>

    s/to see and change quotas/to query status and modify quotas ?



docs/authorization.md (lines 35 - 36)
<https://reviews.apache.org/r/47400/#comment198096>

    Move these two after volumes before weights, please.



docs/authorization.md (line 359)
<https://reviews.apache.org/r/47400/#comment198097>

    We don't support update yet and won't land it in 0.29 ; ). Please leave set and remove
for now.



docs/authorization.md 
<https://reviews.apache.org/r/47400/#comment198098>

    Do you want to write a section about get_quotas instead?



docs/quota.md (line 159)
<https://reviews.apache.org/r/47400/#comment198100>

    s/which the principal is authorized to get/which principal is authorized to query status
(if authorization is enabled)



docs/quota.md (line 188)
<https://reviews.apache.org/r/47400/#comment198101>

    Notes are styled like this:
    ```
    > NOTE: Start with a capital letter
    ```
    
    s/see/query
    s/quota info/quota information



docs/upgrades.md (line 169)
<https://reviews.apache.org/r/47400/#comment198107>

    Thanks a lot for updating this! Please update the deprecations section in the changelog
as well.
    
    Also, please write down that SET_QUOTA_WITH_ROLE and DESTROY_QUOTA_WITH_PRINCIPAL actions
are deprecated as well. This is even more important since they affect all authorizers, not
just the local one.
    
    Some minor comments:
    s/modify/update (let's stick to one terminology; we use modify for all 3 actions)



docs/upgrades.md (line 173)
<https://reviews.apache.org/r/47400/#comment198108>

    s/retrieve/query status (for consistency in terminology)


- Alexander Rukletsov


On May 15, 2016, 5:43 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> -----------------------------------------------------------
> 
> (Updated May 15, 2016, 5:43 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
>     https://issues.apache.org/jira/browse/MESOS-5155
>     https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message