mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 47362: Added a test for the SSL head-of-line blocking issue in MESOS-5340.
Date Mon, 16 May 2016 16:43:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47362/#review133375
-----------------------------------------------------------




3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 730 - 731)
<https://reviews.apache.org/r/47362/#comment197720>

    IIUC, this is an implementation detail, which may change in the future. Currently our
code relies on the callback from lebevent, which is invoked then data is sent. We actually
don't care whether the SSL handshake has completed, we *just* want that a pending socket does
not prevent us from accepting new connections.
    
    How about
    ```
      // We initiate a connection on which we will not send
      // any data. This may prevent the socket from entering
      // ready state and hence the future signaled.
    ```



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 744)
<https://reviews.apache.org/r/47362/#comment197721>

    If you accept the suggestion above, it makes sense to kill this sentence.



3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 755 - 759)
<https://reviews.apache.org/r/47362/#comment197728>

    Why do you construct the response manually instead of using `http::OK`?


- Alexander Rukletsov


On May 13, 2016, 9:46 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47362/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 9:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-5340
>     https://issues.apache.org/jira/browse/MESOS-5340
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test works by creating a connection on which no data is sent (the SSL handshake
does not complete, nor is the socket downgraded). After which, we expect that an HTTP request
should succeed.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 4d237815a03828b915e821c3af78132e2915c610

> 
> Diff: https://reviews.apache.org/r/47362/diff/
> 
> 
> Testing
> -------
> 
> This test fails before the fix in MESOS-5340.
> 
> ```
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from SSLTest
> [ RUN      ] SSLTest.SilentSocket
> ../../../3rdparty/libprocess/src/tests/ssl_tests.cpp:752: Failure
> Failed to wait 15secs for socket
> [  FAILED  ] SSLTest.SilentSocket (15221 ms)
> [----------] 1 test from SSLTest (15221 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (15222 ms total)
> [  PASSED  ] 0 tests.
> [  FAILED  ] 1 test, listed below:
> [  FAILED  ] SSLTest.SilentSocket
> ```
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message