mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.
Date Sat, 14 May 2016 03:36:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47374/#review133249
-----------------------------------------------------------



Bad patch!

Reviews applied: [47374, 47216, 47150, 47215, 47214, 47213, 47212, 47205, 47149]

Failed command: ./support/apply-review.sh -n -r 47213

Error:
2016-05-14 03:36:17 URL:https://reviews.apache.org/r/47213/diff/raw/ [1540/1540] -> "47213.patch"
[1]
error: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp: does not exist in
index

Full log: https://builds.apache.org/job/mesos-reviewbot/13061/console

- Mesos ReviewBot


On May 13, 2016, 11:31 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47374/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 11:31 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Kapil Arya, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives external projects easier access to the test helpers used in
> mesos tests.  
> 
> For example, a module writer may want to write a test like 
> `src/tests/oversubscription_tests.cpp`.  To build and link against 
> this library, the module writer would mimic the build flags for tests:
> ```
> my_module_CPPFLAGS =                   \
>   -I$(ZOOKEEPER)/include               \
>   -I$(ZOOKEEPER)/generated             \
>   -DSOURCE_DIR=\"$(abs_top_srcdir)\"   \
>   -DBUILD_DIR=\"$(abs_top_builddir)\"  \
>   ...
> ```
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
> 
> Diff: https://reviews.apache.org/r/47374/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message