mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.
Date Fri, 13 May 2016 20:37:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47089/#review133196
-----------------------------------------------------------




src/tests/health_check_tests.cpp (line 1015)
<https://reviews.apache.org/r/47089/#comment197477>

    Why did this change?



src/tests/health_check_tests.cpp (line 1057)
<https://reviews.apache.org/r/47089/#comment197479>

    Ideally this uses `->` instead of `.get().` but if you'd like to send a sweep of this
file separately I'll be happy to commit it.



src/tests/health_check_tests.cpp (line 1059)
<https://reviews.apache.org/r/47089/#comment197480>

    It looks like the clock needs to be paused before the task is launched? Otherwise we may
have too much time advance between launching the task and pausing the clock, no?


- Benjamin Mahler


On May 7, 2016, 11:46 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47089/
> -----------------------------------------------------------
> 
> (Updated May 7, 2016, 11:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Niklas Nielsen, Timothy Chen, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-1653
>     https://issues.apache.org/jira/browse/MESOS-1653
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Waited for first statusUpdate before advance clock in GracePeriod test.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 
> 
> Diff: https://reviews.apache.org/r/47089/diff/
> 
> 
> Testing
> -------
> 
> Test with
> 
> ```
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.GracePeriod" --verbose
--gtest_break_on_failure --gtest_repeat=-1
> ```
> 
> more than 1500 iteractions in my slow machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message