mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.
Date Fri, 13 May 2016 18:56:21 GMT


> On May 13, 2016, 3:27 p.m., Till Toenshoff wrote:
> > I am not convinced that this test adds anything. libprocess handles the authentication
and hence testing a single endpoint as an integration test seems to get us all the information
we need -> "have we properly integrated the http-endpoint-authentication of libprocess
into the slave?". 
> > 
> > Note that a failed authentication will never hit the implementation of the (slave)
endpoint itself, hence we will not get any endpoint implementation specific information out
of such test.
> > 
> > Adding more endpoints into this test IMHO does not add any value and I believe we
should remove the second one and stick with a single one - e.g. /state or ANY other randomly
chosen one.

Ok.. We may discard this patch if it is not needed. Till, would you let me know the name of
the test case for testing libprocess to handle the authentication?


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47062/#review133126
-----------------------------------------------------------


On May 13, 2016, 2:24 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47062/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 2:24 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5316
>     https://issues.apache.org/jira/browse/MESOS-5316
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Testcase SlaveTest.HTTPEndpointsBadAuthentication is updated to use
> authentication when hitting '/containers' endpoint as well as when
> bad credentials are provided.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 3f653354869987dce3f5fbc4513b6f3466a718cb 
> 
> Diff: https://reviews.apache.org/r/47062/diff/
> 
> 
> Testing
> -------
> 
> sudo make -j2 check 
> On Ubuntu 16.04
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message