mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.
Date Fri, 13 May 2016 18:35:18 GMT


> On May 13, 2016, 5:38 p.m., Zhitao Li wrote:
> > src/master/quota_handler.cpp, line 464
> > <https://reviews.apache.org/r/47274/diff/1/?file=1380254#file1380254line464>
> >
> >     I'd like to keep using vector because we know the expected size in the beginning
and can reserve the capacity beforehand. It's slightly more memory efficient than list (which
requires one memory per push_back IIUIC).
> >     
> >     I can still avoid index by using vector::const_iterator to loop in it. It should
be no difference interface wise.

Ok.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47274/#review133164
-----------------------------------------------------------


On May 12, 2016, 12:48 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47274/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 12:48 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5336
>     https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Authorize what quota can be seen by GET_QUOTA_BY_ROLE.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
>   include/mesos/authorizer/authorizer.proto 32492a59ad95df3bb673ec42321518f86c11af59

>   src/authorizer/local/authorizer.cpp e95435327bb3b6f447e814b8657bce8084535346 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c 
>   src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64 
> 
> Diff: https://reviews.apache.org/r/47274/diff/
> 
> 
> Testing
> -------
> 
> Unit test.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message