mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 47221: Windows: Used `os::random` in libprocess.
Date Fri, 13 May 2016 15:31:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47221/#review133130
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/tests/sequence_tests.cpp (line 258)
<https://reviews.apache.org/r/47221/#comment197422>

    missing `<stout/os.hpp>` include?


- Joris Van Remoortere


On May 12, 2016, 10:19 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47221/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 10:19 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Michael Park.
> 
> 
> Bugs: MESOS-5372
>     https://issues.apache.org/jira/browse/MESOS-5372
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Used `os::random` in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/sequence_tests.cpp 566393fbf3f19644b86843f07194d1de36a2015e

> 
> Diff: https://reviews.apache.org/r/47221/diff/
> 
> 
> Testing
> -------
> 
> OSX: make ckeck
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message