mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 47339: Refactored URL path endpoint extraction.
Date Fri, 13 May 2016 14:12:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47339/
-----------------------------------------------------------

(Updated May 13, 2016, 4:12 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
-------

Addressed Alex's issues (added `extractEndpoint` to `Master::Http`)


Repository: mesos


Description
-------

Extracting the HTTP endpoint from `URL.path` is now done in a separate
function in `Slave::Http`, making `Slave::Http::extractEndpoint`
consistent with the one in `Master::Http`.


Diffs (updated)
-----

  src/master/http.cpp 6cefcc8b6ddcfe4098521e838bfdc95936fe7476 
  src/master/master.hpp bd0fa9870199bb8792f6c2b8c24ad93da4f027e0 
  src/slave/http.cpp 0fb9b81c4a87250e454e3380c61cf9037454810b 
  src/slave/slave.hpp be622d31de29a242a6c71fd8dedb06aeff19142d 

Diff: https://reviews.apache.org/r/47339/diff/


Testing
-------

make check


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message