mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 47313: Add authentication documentation to authenticated libprocess endpoints.
Date Fri, 13 May 2016 07:59:53 GMT


> On May 12, 2016, 6:37 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/logging.cpp, line 97
> > <https://reviews.apache.org/r/47313/diff/1/?file=1381382#file1381382line97>
> >
> >     Strictly speaking, libprocess endpoints can be both authentication-enabled and
not. This depends on how libprocess is initialized.

Like we discussed offline, the issue here is that whether a libprocess endpoint is authorized
or not depends not only if on whether the endpoint supports authorization, but also on the
way libprocess itself was initialized. Since we currently expose these endpoint through either
master or agent processes this is not an issue here as int that case libprocess endpoints
will behave consistently with what was specified by the user when these mesos processes where
started. If the endpoints are exposed by other processes the situation is less clear.

As `AUTHENTICATION` just causes some documentation to be emitted in the endpoint help which
is currently only accessible via mesos masters/agents let's give the user a consistent story
there and actually document the behavior for that case (right now the documentation is just
wrong). Should cases arise where the documentation is really misleading we can revisit this
and try to make the help strings more reusable across libprocess users.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47313/#review132941
-----------------------------------------------------------


On May 12, 2016, 3:55 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47313/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 3:55 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add authentication documentation to authenticated libprocess endpoints.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/logging.cpp ad7aa3aabbfc4a496e7e624a691a72e45c72e35d 
>   3rdparty/libprocess/src/metrics/metrics.cpp 65b58433158c51cebace9b591d4121e8d9a59ecc

>   3rdparty/libprocess/src/profiler.cpp 9b2f106cc7db1ff0b94c72ed55188d94799cf7df 
> 
> Diff: https://reviews.apache.org/r/47313/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, clang-trunk, w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message