mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 47324: Update leveldb.
Date Fri, 13 May 2016 07:27:55 GMT


> On May 13, 2016, 4:38 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [47324]
> > 
> > Failed command: ./support/apply-review.sh -n -r 47324
> > 
> > Error:
> > 2016-05-13 04:38:10 URL:https://reviews.apache.org/r/47324/diff/raw/ [4739/4739]
-> "47324.patch" [1]
> > error: missing binary patch data for '3rdparty/leveldb-1.18.tar.gz'
> > error: binary patch does not apply to '3rdparty/leveldb-1.18.tar.gz'
> > error: 3rdparty/leveldb-1.18.tar.gz: patch does not apply
> > 
> > Full log: https://builds.apache.org/job/mesos-reviewbot/13038/console
> 
> Zhiwei Chen wrote:
>     The rbtools does not support binary patch, please apply this patch to your rbtools.
https://reviews.reviewboard.org/r/7571/diff/1#index_header
>     
>     Or use git diff --binary to generate a patch file and upload it through reviewboard
Web UI.
>     
>     I will help you test on ppc64le when you fix this.

Thank you so much for your kindly help. @zhiwei. Sorry to forgot remind @janisz before. I
think we may document this at the `submitting a patch`. :-)


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/#review133030
-----------------------------------------------------------


On May 12, 2016, 8:46 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47324/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 8:46 p.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-970
>     https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update leveldb to 1.18.
> Remove patch that is already included in latest leveldb release.
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
>   3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
>   LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
>   src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5

> 
> Diff: https://reviews.apache.org/r/47324/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu amd_64 need to test on PPC
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message