mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Review Request 47337: Fixed erroneous `CHECK` in the command executor.
Date Fri, 13 May 2016 07:19:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47337/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
-------

There might be instances when a command might get completed
and is not required to have an explicit `Kill` request e.g.,
"echo hello world" etc. Unfortunately, all these cases can
lead to the `CHECK` failing since `reaped` can be invoked
directly.


Diffs
-----

  src/launcher/http_command_executor.cpp c62fe3ee6ae06536cbb89ea208b669790efe4b39 

Diff: https://reviews.apache.org/r/47337/diff/


Testing
-------

make check (This would be tested automatically when we move to the executor shim I am working
on i.e. MESOS-5302)


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message