mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.
Date Fri, 13 May 2016 04:08:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/
-----------------------------------------------------------

(Updated May 13, 2016, 4:08 a.m.)


Review request for mesos and Michael Park.


Changes
-------

benm's comments. NNFR.


Bugs: MESOS-5370
    https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
-------

The logic is now moved to Flag::load() keep the duplicate checking logic
for names and aliases in one place.


Diffs (updated)
-----

  3rdparty/stout/include/stout/flags/flags.hpp 02584e28b938bba738c2e32b3cb7a04a47693853 

Diff: https://reviews.apache.org/r/46863/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message