mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <>
Subject Re: Review Request 46669: Added deprecation support to Flag name.
Date Fri, 13 May 2016 04:08:18 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 13, 2016, 4:08 a.m.)

Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


benm's comments. NNFR.

Bugs: MESOS-5370

Repository: mesos


This allows callers of Flag to explicitly specify a flag name or its
alias as deprecated. Loading of deprecated flag name will result in a
deprecation warning being returned.

Diffs (updated)

  3rdparty/stout/ 45dd8f39de9fa34cc11befbe842319079685db02 
  3rdparty/stout/include/stout/flags/flag.hpp d869904d13301fd4b3fdb037e6279d3a4018ac1e 
  3rdparty/stout/include/stout/flags/flags.hpp 02584e28b938bba738c2e32b3cb7a04a47693853 
  3rdparty/stout/include/stout/subcommand.hpp 4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
  3rdparty/stout/tests/flags_tests.cpp a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 



make check


Vinod Kone

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message