mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46242: Removed a check in Reserve operation validation.
Date Fri, 13 May 2016 03:42:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/#review133024
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46242]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 13, 2016, 12:25 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46242/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos, Adam B and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5212
>     https://issues.apache.org/jira/browse/MESOS-5212
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a dynamic reservation is made by an operator
> or framework with no principal, this patch removes
> the check which enforced that the principal in
> ReservationInfo must be None() in that case.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp f458100d22ec1f9f10921c1c91b6931a5671e28f 
>   src/tests/master_validation_tests.cpp 8a5bf9477596f13b2fb3a1348337ad2fe53a034d 
>   src/tests/reservation_endpoints_tests.cpp f014290ed9f279df4c774aeb7ce7bd38fd1cc854

> 
> Diff: https://reviews.apache.org/r/46242/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message