mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 47209: Establish TCP connection after backing off.
Date Fri, 13 May 2016 01:57:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47209/#review133016
-----------------------------------------------------------




src/slave/slave.cpp (line 996)
<https://reviews.apache.org/r/47209/#comment197322>

    Whoops, this will crash when master is None. How about you move it down to where we've
decided we need to authenticate (below the LOG(INFO)). This makes it a bit more symmetric
with the registration path).
    
    Also could you include the following?
    
    ```
    // Ensure there is a link to the master before we start communicating with it.
    ```


- Ben Mahler


On May 12, 2016, 6:18 p.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47209/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 6:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-5330
>     https://issues.apache.org/jira/browse/MESOS-5330
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Establish TCP connection after backing off.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47209/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also started a master and agent and captured a tcpdump to verify the connection is only
established _after_ the registration backoff.
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message