mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 47209: Establish TCP connection after backing off.
Date Thu, 12 May 2016 18:04:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47209/#review132956
-----------------------------------------------------------




src/slave/slave.cpp (line 966)
<https://reviews.apache.org/r/47209/#comment197233>

    Why not call `link` inside the `authenticate()` function in a similar manner to how you've
called it within `doReliableRegistration()`?



src/slave/slave.cpp (line 1361)
<https://reviews.apache.org/r/47209/#comment197235>

    How about the following comment here:
    
    ```
      // Ensure there is a link to the master before we start
      // communicating with it. We want to `link` after the
      // initial registration backoff in order to avoid all
      // of the agents establishing connections with the
      // master at once. See MESOS-5330.
    ```


- Ben Mahler


On May 11, 2016, 12:58 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47209/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 12:58 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-5330
>     https://issues.apache.org/jira/browse/MESOS-5330
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Establish TCP connection after backing off.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47209/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also started a master and agent and captured a tcpdump to verify the connection is only
established _after_ the registration backoff.
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message