mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.
Date Wed, 11 May 2016 18:20:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132707
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46965]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 11, 2016, 9:16 a.m., Chen Nan Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 9:16 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using ARIA landmarks to identify regions of a page.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> -------
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So for the
header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message