mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 37989: Enhanced log message when launching mesos docker executor.
Date Wed, 11 May 2016 10:59:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37989/#review132636
-----------------------------------------------------------



Patch looks great!

Reviews applied: [37989]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 11, 2016, 3:30 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37989/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 3:30 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5348
>     https://issues.apache.org/jira/browse/MESOS-5348
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enhanced log message when launching mesos docker executor.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
> 
> Diff: https://reviews.apache.org/r/37989/diff/
> 
> 
> Testing
> -------
> 
> I0511 11:26:18.176844 29178 docker.cpp:1236] Launching 'mesos-docker-executor' with flags
'--container="mesos-7f581417-e295-474f-b038-3900ee0479dc-S1.b19cbf40-d69f-4507-9019-dbe61b9eff6b"
--docker="docker" --docker_socket="/var/run/docker.sock" --help="false" --initialize_driver_logging="true"
--launcher_dir="/root/src/mesos/m1/mesos/build/src" --logbufsecs="0" --logging_level="INFO"
--mapped_directory="/mnt/mesos/sandbox" --quiet="false" --sandbox_directory="/tmp/mesos/slaves/7f581417-e295-474f-b038-3900ee0479dc-S1/frameworks/7f581417-e295-474f-b038-3900ee0479dc-0001/executors/test_mesos/runs/b19cbf40-d69f-4507-9019-dbe61b9eff6b"
--stop_timeout="0ns"'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message