mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhiwei Chen <zhiw...@gmail.com>
Subject Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.
Date Wed, 11 May 2016 01:17:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46816/
-----------------------------------------------------------

(Updated May 11, 2016, 9:17 a.m.)


Review request for mesos, zhou xing, Jie Yu, James Peach, Kapil Arya, and Vinod Kone.


Bugs: MESOS-5326
    https://issues.apache.org/jira/browse/MESOS-5326


Repository: mesos


Description (updated)
-------

The symbolic link of include/slave to include/agent uses an absolute path to $(DESTDIR)/include.
But $(DESTDIR) is the tmp dir in build time, it will not exist in target machine.


Diffs
-----

  src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 

Diff: https://reviews.apache.org/r/46816/diff/


Testing
-------

Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, should use relative
path.

I am not sure if this copy-template-and-create-symlink should be removed of not, since MESOS-3782
& MESOS-5230 already completed. This blocked our daily build.


Thanks,

Zhiwei Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message