mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhiwei Chen <zhiw...@gmail.com>
Subject Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.
Date Wed, 11 May 2016 01:17:48 GMT


> On May 11, 2016, 7:12 a.m., Vinod Kone wrote:
> > Can you copy the description from the ticket to the description section in this
review?

Done, thanks.


- Zhiwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46816/#review132565
-----------------------------------------------------------


On May 5, 2016, 2:23 p.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46816/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 2:23 p.m.)
> 
> 
> Review request for mesos, zhou xing, Jie Yu, James Peach, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-5326
>     https://issues.apache.org/jira/browse/MESOS-5326
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix the absolute symlink path issue of include/slave.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
> 
> Diff: https://reviews.apache.org/r/46816/diff/
> 
> 
> Testing
> -------
> 
> Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, should use
relative path.
> 
> I am not sure if this copy-template-and-create-symlink should be removed of not, since
MESOS-3782 & MESOS-5230 already completed. This blocked our daily build.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message