mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 46881: Added authorization callback for '/logging/toggle'.
Date Tue, 10 May 2016 21:24:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46881/#review132532
-----------------------------------------------------------


Ship it!





src/common/http.cpp (lines 590 - 592)
<https://reviews.apache.org/r/46881/#comment196764>

    Maybe move this closer to AuthorizationCallbacks declaration?


- Kapil Arya


On May 10, 2016, 4:38 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46881/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
>     https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an authorization callback to the
> generating function `CreateAuthorizationCallbacks`
> for the '/logging/toggle' endpoint.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 
> 
> Diff: https://reviews.apache.org/r/46881/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message