mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.
Date Tue, 10 May 2016 17:55:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132496
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/webui/master/static/css/mesos.css (line 5)
<https://reviews.apache.org/r/46965/#comment196717>

    Because this isn't belongs to `BOOTSTRAP OVERRIEDS`, please put it at the end of this
css style file.


- haosdent huang


On May 8, 2016, 12:04 p.m., Chen Nan Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> -----------------------------------------------------------
> 
> (Updated May 8, 2016, 12:04 p.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using ARIA landmarks to identify regions of a page.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> -------
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So for the
header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message