mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 47053: Windows: [2/2] Used `os::random` in `slave.cpp`.
Date Tue, 10 May 2016 16:51:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47053/#review132477
-----------------------------------------------------------


Ship it!




Pending Joris's suggestion, which I strongly agree with.

- Alex Clemmer


On May 6, 2016, 4:17 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47053/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 4:17 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [2/2] Used `os::random` in `slave.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47053/diff/
> 
> 
> Testing
> -------
> 
> OSX: make
> Windows: msbuild
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message