mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.
Date Tue, 10 May 2016 15:51:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47054/#review132455
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/zookeeper-06d3f3f.patch (lines 142 - 150)
<https://reviews.apache.org/r/47054/#comment196630>

    Can we add a comment here as to what we are doing, and why?
    This will make it easier for someone to update this file in the future.


- Joris Van Remoortere


On May 6, 2016, 4:17 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47054/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 4:17 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Removed `Zookeeper's` NTDDI_VERSION.
> 
> 
> Diffs
> -----
> 
>   3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 
> 
> Diff: https://reviews.apache.org/r/47054/diff/
> 
> 
> Testing
> -------
> 
> OSX: make
> Windows: msbuild
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message