mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).
Date Mon, 09 May 2016 10:28:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46866/#review132237
-----------------------------------------------------------




3rdparty/libprocess/include/process/http.hpp (line 85)
<https://reviews.apache.org/r/46866/#comment196419>

    Is there a design doc or an overall explanation of how authorization will be performed
in libprocess?
    
    I find it cool if we provide an API which can be used in Mesos, similar to how authentication
works, also to keep them consistent.
    
    Of the top of my head, how about changing `route` to use a set of flags, similar on how
streams work in the stdlib so we can define if you want authentication + authorization, etc.



3rdparty/libprocess/src/process.cpp (line 3279)
<https://reviews.apache.org/r/46866/#comment196428>

    Why no setting this variable close to were it will be used. I always liked the concept
of data locality, so someone doesn't have to scroll up to see where a variable was set.


- Alexander Rojas


On May 6, 2016, 11:13 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46866/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 11:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
>     https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables libprocess to store and execute
> authorization callbacks provided by a client
> application.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297

>   3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46866/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message