mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 46936: Documented the agent endpoint '/flags'.
Date Mon, 09 May 2016 08:01:37 GMT


> On May 5, 2016, 4:15 p.m., Neil Conway wrote:
> > src/slave/http.cpp, lines 356-357
> > <https://reviews.apache.org/r/46936/diff/1/?file=1369799#file1369799line356>
> >
> >     +1, although I'd say "The current principal should be ..."

I'm ESL, but for me "current" in this context sounds like a principal which is stored or cached
by Mesos, and hence "current" to the context. But we are talking about the principal from
the request, which may be observed by Mesos for the first time. Maybe we can find a better
word, e.g. provided, specified, or "request principal"?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46936/#review131848
-----------------------------------------------------------


On May 3, 2016, 2:36 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46936/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 2:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/slave/flags.md b2740e6a4ce4bb8c25de07071bafbf174adf9137 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
> 
> Diff: https://reviews.apache.org/r/46936/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message