mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 37945: Removed `flags.docker_registry` in docker test.
Date Sun, 08 May 2016 23:25:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37945/#review132191
-----------------------------------------------------------



Patch looks great!

Reviews applied: [37945]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 8, 2016, 10:16 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37945/
> -----------------------------------------------------------
> 
> (Updated May 8, 2016, 10:16 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default value of `flags.docker_registry` is already
> `https://registry-1.docker.io`, there is no need to set it again
> in test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 69505c922617273effc2eb52b0c567a3c01bf640

>   src/tests/containerizer/runtime_isolator_tests.cpp a3b6793829ce1d5049fe0f963f8bfb1e717400be

> 
> Diff: https://reviews.apache.org/r/37945/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message