mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46975: Add title and heading in Mesos Log Page.
Date Sun, 08 May 2016 15:29:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46975/#review132175
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46975]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 8, 2016, 11:52 a.m., Chen Nan Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46975/
> -----------------------------------------------------------
> 
> (Updated May 8, 2016, 11:52 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
>     https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add title and heading in Mesos Log Page.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/pailer.html 19e0981143bd7e8372b49f4f036867e9dd05727a 
> 
> Diff: https://reviews.apache.org/r/46975/diff/
> 
> 
> Testing
> -------
> 
> Mesos log page should have a title. for details: https://www.w3.org/TR/WCAG20-TECHS/H25
> 
> And Should give a heading to tell screen reader that the content in the page is "Mesos
log"
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message