mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.
Date Sat, 07 May 2016 18:12:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46618/#review132141
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46618]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 5:33 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46618/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 5:33 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added containerId to failure message when there are duplicate volumes
> in one container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 76d0fa183c9099584da6a4ee1e5d474b871310c3

> 
> Diff: https://reviews.apache.org/r/46618/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsFailedWithSameVolumes"
--verbose
> ....
> E0506 13:28:57.268867 22904 slave.cpp:3995] Container '9d3f864f-8907-47d5-b0b1-657bf06ed12f'
for executor '59d6e794-7d6a-479d-9d15-5026661eb51d' of framework a81cc2e7-e802-458b-9ba2-8c7f7eab83d0-0000
failed to start: Found duplicate docker volume with driver 'driver1' and name 'name1' for
container 9d3f864f-8907-47d5-b0b1-657bf06ed12f
> ....
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message