mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 47088: Dropped http status check in HealthCheckTest.HealthStatusChange.
Date Sat, 07 May 2016 09:07:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47088/
-----------------------------------------------------------

(Updated May 7, 2016, 9:07 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Greg Mann, Artem Harutyunyan, Neil
Conway, and Timothy Chen.


Changes
-------

Add @hartem in reviewers and update `Testing Done`.


Bugs: MESOS-1802
    https://issues.apache.org/jira/browse/MESOS-1802


Repository: mesos


Description
-------

Dropped http status check because so far we could not guarantee the
http queries order match the `statusUpdate` order.


Diffs
-----

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/47088/diff/


Testing (updated)
-------

Using

```
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.HealthStatusChange" --verbose
--gtest_break_on_failure --gtest_repeat=-1
```

More than 1000 interactions in my slow vm.


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message