mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.
Date Thu, 05 May 2016 23:52:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46874/#review131968
-----------------------------------------------------------



@Yu Jie and @Gilbert, any comments on the message? My thinking is that we can focus on the
`flags` that `mesos-containerizer` will be used, so I still want to use the log message as
in my patch now. 

When I was debugging container part, I often update this part by adding the log manually to
see the flags that will be used by the `mesos-containerizer`, enhancing the message here can
help improve the debugability well.

- Guangya Liu


On 五月 1, 2016, 6:24 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46874/
> -----------------------------------------------------------
> 
> (Updated 五月 1, 2016, 6:24 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The mesos-containerizer will help prepare the rootfs, mount and
> network conf for a container when launch with some flags, it
> would be helpful to print out all of the mesos-containerizer launch
> flags for trouble shooting.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 8d538954d6e1f13e833d75c2eaa37e700278ee0c

> 
> Diff: https://reviews.apache.org/r/46874/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> Enhanced log message:
> I0501 14:12:17.910006  5991 containerizer.cpp:1175] Launching 'mesos-containerizer' with
flags as '--command="{"shell":true,"value":"\/root\/src\/mesos\/m1\/mesos\/build\/src\/mesos-executor"}"
--commands="{"commands":[{"shell":true,"value":"#!\/bin\/sh\nset -x -e\n\/root\/src\/mesos\/m1\/mesos\/build\/src\/mesos-containerizer
mount --help=\"false\" --operation=\"make-rslave\" --path=\"\/\"\ngrep -E '\/tmp\/mesos\/.+'
\/proc\/self\/mountinfo | grep -v 'a2cc264f-72eb-416c-b876-e4a98484a0ab' | cut -d' ' -f5 |
xargs --no-run-if-empty umount -l || true \n"}]}" --help="false" --pipe_read="8" --pipe_write="9"
--sandbox="/tmp/mesos/slaves/5763efb9-8e12-4bfc-b06b-2a324881608d-S0/frameworks/425afd24-796d-42dd-98c0-593f1d71e246-0000/executors/test/runs/a2cc264f-72eb-416c-b876-e4a98484a0ab"
--user="root"'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message