mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
Date Thu, 05 May 2016 16:10:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review131846
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (lines 197 - 199)
<https://reviews.apache.org/r/42386/#comment195888>

    `FrameworkInfo.capabilities` is a repeated field. This means we plan to add more capabilities
in the future. For now, we use only revocable resources in this fixture, but this may change.
Could you please update the signature to take a vector or a list of capabilities?
    
    I can imagine that in the future we may want to pull out all these helpers and consolidate
them.


- Alexander Rukletsov


On April 29, 2016, 9:56 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 9:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, Joris Van
Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
>     https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 53a759ce0ebea87cc564a22cb2d34e54870f782b

> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> -------
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message