mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.
Date Wed, 04 May 2016 04:17:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46954/#review131622
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46954]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 4, 2016, 1:48 a.m., Chen Nan Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46954/
> -----------------------------------------------------------
> 
> (Updated May 4, 2016, 1:48 a.m.)
> 
> 
> Review request for mesos and Zhiwei Chen.
> 
> 
> Bugs: MESOS-5201
>     https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensuring that id attributes are unique on a Web page.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/directives/tableHeader.html 448f67ef20c279fdd542890158fb9f96a10ebebc

> 
> Diff: https://reviews.apache.org/r/46954/diff/
> 
> 
> Testing
> -------
> 
> Have checked with the patch by firebug, the ID of each table header is different with
each other.
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message