mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).
Date Wed, 04 May 2016 03:24:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46866/#review131613
-----------------------------------------------------------




3rdparty/libprocess/include/process/http.hpp (lines 89 - 91)
<https://reviews.apache.org/r/46866/#comment195628>

    Is that the correct line-break here? Can we make it better?



3rdparty/libprocess/include/process/http.hpp (lines 89 - 100)
<https://reviews.apache.org/r/46866/#comment195629>

    Since this is a public header, let's add comment blocks.



3rdparty/libprocess/src/process.cpp (line 484)
<https://reviews.apache.org/r/46866/#comment195630>

    Having non-pod global vars isn't good! Maybe use a pointer instead?


- Kapil Arya


On May 1, 2016, 6:28 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46866/
> -----------------------------------------------------------
> 
> (Updated May 1, 2016, 6:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
>     https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables libprocess to store and execute
> authorization callbacks provided by a client
> application.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297

>   3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46866/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message