mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsSingleVolume".
Date Wed, 04 May 2016 02:24:23 GMT


> On 五月 3, 2016, 9:05 p.m., Gilbert Song wrote:
> > src/tests/containerizer/docker_volume_isolator_tests.cpp, lines 272-273
> > <https://reviews.apache.org/r/46140/diff/6/?file=1369669#file1369669line272>
> >
> >     Do we need it on this test?

I want to make sure that the option works as I can see that in the log message there are options
for the mount operation.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46140/#review131538
-----------------------------------------------------------


On 五月 3, 2016, 7:51 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46140/
> -----------------------------------------------------------
> 
> (Updated 五月 3, 2016, 7:51 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
>     https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test "ROOT_CommandTaskNoRootfsSingleVolume".
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp 070d52018e82ed3e46fb1b79714ffc4716f6a306

>   src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46140/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsSingleVolume"
--verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message