mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.
Date Tue, 03 May 2016 09:38:13 GMT


> On May 2, 2016, 5:53 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/src/process.cpp, line 1007
> > <https://reviews.apache.org/r/45995/diff/1/?file=1338528#file1338528line1007>
> >
> >     I am no sure if use `processes_route` style to keep consistent with `process_manager`.

Good catch!


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/#review131340
-----------------------------------------------------------


On April 11, 2016, 1:39 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45995/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 1:39 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5144
>     https://issues.apache.org/jira/browse/MESOS-5144
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed memory leak of `Route` in `finalize()` in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/45995/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message