mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46505: Removed MethodNotAllowed error string creation.
Date Tue, 03 May 2016 06:14:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46505/#review131461
-----------------------------------------------------------



Bad patch!

Reviews applied: [46505, 46504]

Failed command: ./support/apply-review.sh -n -r 46504

Error:
2016-05-03 06:14:46 URL:https://reviews.apache.org/r/46504/diff/raw/ [2082/2082] -> "46504.patch"
[1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12854/console

- Mesos ReviewBot


On May 3, 2016, 12:20 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46505/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4126
>     https://issues.apache.org/jira/browse/MESOS-4126
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed hard coding of MethodNotAllowed Reponse body in master and slave.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
> 
> Diff: https://reviews.apache.org/r/46505/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message