mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.
Date Tue, 03 May 2016 01:43:39 GMT


> On May 2, 2016, 9:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 1081-1083
> > <https://reviews.apache.org/r/46873/diff/2/?file=1368131#file1368131line1081>
> >
> >     I think we should still set MESOS_SANDBOX to 'directory' for command executor
itself because the executor uses host filesystem.
> >     
> >     Before the command executor 'exec' the user task, it should set `MNESOS_SANDBOX`
to `/mnt/mesos/sandbox`.

second thoughts. maybe this is fine since we already do special things for command executor.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46873/#review131386
-----------------------------------------------------------


On May 2, 2016, 3:04 p.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46873/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 3:04 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
>     https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed MESOS_SANDBOX env in unified containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 8d53895 
> 
> Diff: https://reviews.apache.org/r/46873/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + gcc 4.8.4)
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message