mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.
Date Mon, 02 May 2016 23:59:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46858/
-----------------------------------------------------------

(Updated May 2, 2016, 11:59 p.m.)


Review request for mesos, Gilbert Song, Ian Downes, and Timothy Chen.


Changes
-------

Added more notes.


Bugs: MESOS-5239
    https://issues.apache.org/jira/browse/MESOS-5239


Repository: mesos


Description
-------

In filesystem/linux isolator, we will need to make sure the mount that
contains the agent's working directory is a shared mount in its own
peer group so that cloning the host mount table (e.g., when launching
a container with a new mount namespace) does not create an extra
reference to the mounts under the agent's work_dir.

However, if the mount containing the agent's working directory is
already a shared mount in its own peer group, we don't have to create
another bind mount for the agent's working directory. This patch
allows the filesystem/linux isolator to skip the bind mount if
possible.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 8805143a2e5569a3479bbeab26cda12d2cd396a9

  src/tests/containerizer/filesystem_isolator_tests.cpp 29d313051865761306029f331eb36684c3252ffb


Diff: https://reviews.apache.org/r/46858/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message