mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 46806: Fixed and illustrated process::initialize ordering.
Date Mon, 02 May 2016 17:50:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46806/
-----------------------------------------------------------

(Updated May 2, 2016, 10:50 a.m.)


Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and Kapil Arya.


Changes
-------

Some commenting tweaks.


Bugs: MESOS-5304
    https://issues.apache.org/jira/browse/MESOS-5304


Repository: mesos


Description
-------

Moves `metrics::initialize` below the creation of the `help` process.

Adds a comment block to explain the ordering of process creation in 
`process::initialize`.


Diffs (updated)
-----

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46806/diff/


Testing
-------

make check

Also double-checked that `/help/metrics/snapshot` shows up on both master and agent.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message