mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 46872: Updated quota.md and weights.md for set quota and update weight.
Date Mon, 02 May 2016 16:01:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46872/#review131319
-----------------------------------------------------------




docs/quota.md (line 87)
<https://reviews.apache.org/r/46872/#comment195252>

    In case you want to change this to file:
    s/definition/file



docs/quota.md (line 89)
<https://reviews.apache.org/r/46872/#comment195251>

    initialy this was not intended to be a file (but just the json message below). In that
case the example also works... in case you want to change this to file please make it consistent
and rename that variable to something like quota.json?



docs/weights.md (line 38)
<https://reviews.apache.org/r/46872/#comment195254>

    see above



docs/weights.md (line 40)
<https://reviews.apache.org/r/46872/#comment195253>

    see above


Could you check whether this is an issue also with other endpoints?

- Joerg Schad


On May 1, 2016, 6:42 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46872/
> -----------------------------------------------------------
> 
> (Updated May 1, 2016, 6:42 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and haosdent huang.
> 
> 
> Bugs: MESOS-5313
>     https://issues.apache.org/jira/browse/MESOS-5313
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There should be a @ before the json file when using "curl -d".
> 
> 
> Diffs
> -----
> 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/weights.md 59d1579ed691524185c52ccd0bc26eadfbe167c2 
> 
> Diff: https://reviews.apache.org/r/46872/diff/
> 
> 
> Testing
> -------
> 
> root@mesos002:~/test# cat jsonMessageBody
> {
> 	"role": "role1",
> 	"guarantee": [{
> 		"name": "cpus",
> 		"type": "SCALAR",
> 		"scalar": {
> 			"value": 1
> 		}
> 	}, {
> 		"name": "mem",
> 		"type": "SCALAR",
> 		"scalar": {
> 			"value": 128
> 		}
> 	}]
> }
> 
> root@mesos002:~/test# curl -d @jsonMessageBody -X POST http://192.168.56.12:5050/quota
> 
> root@mesos002:~/test# curl -X GET http://192.168.56.12:5050/quota 2>/dev/null|python
-m json.tool
> {
>     "infos": [
>         {
>             "guarantee": [
>                 {
>                     "name": "cpus",
>                     "role": "*",
>                     "scalar": {
>                         "value": 1.0
>                     },
>                     "type": "SCALAR"
>                 },
>                 {
>                     "name": "mem",
>                     "role": "*",
>                     "scalar": {
>                         "value": 128.0
>                     },
>                     "type": "SCALAR"
>                 }
>             ],
>             "role": "role1"
>         }
>     ]
> }
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message