mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.
Date Sun, 01 May 2016 05:53:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46873/#review131260
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (line 1082)
<https://reviews.apache.org/r/46873/#comment195158>

    One issue is that some tasks without rootfs but with volume or network info may also have
container info, for such tasks, I think that we should not mark the sandbox as /mnt/mesos/sandbox
but still use `directory`?
    
    https://github.com/apache/mesos/blob/master/src/cli/execute.cpp#L530-L575 
    
    BTW: Can you please make your patch depend on https://reviews.apache.org/r/46807


- Guangya Liu


On 五月 1, 2016, 5:28 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46873/
> -----------------------------------------------------------
> 
> (Updated 五月 1, 2016, 5:28 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed MESOS_SANDBOX env in unified containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 8d538954d6e1f13e833d75c2eaa37e700278ee0c

> 
> Diff: https://reviews.apache.org/r/46873/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message