From reviews-return-32690-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Apr 30 02:01:42 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2FBE219B77 for ; Sat, 30 Apr 2016 02:01:42 +0000 (UTC) Received: (qmail 95750 invoked by uid 500); 30 Apr 2016 02:01:42 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 95721 invoked by uid 500); 30 Apr 2016 02:01:42 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 95703 invoked by uid 99); 30 Apr 2016 02:01:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 Apr 2016 02:01:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A183F2B444C; Sat, 30 Apr 2016 02:01:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8829509817698581006==" MIME-Version: 1.0 Subject: Re: Review Request 46669: Added deprecation support to Flag name. From: Vinod Kone To: Ben Mahler , Michael Park , Greg Mann Cc: Vinod Kone , mesos Date: Sat, 30 Apr 2016 02:01:36 -0000 Message-ID: <20160430020136.26196.91950@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46669/ X-Sender: Vinod Kone References: <20160429190858.26230.6124@reviews.apache.org> In-Reply-To: <20160429190858.26230.6124@reviews.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============8829509817698581006== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/ ----------------------------------------------------------- (Updated April 30, 2016, 2:01 a.m.) Review request for mesos, Ben Mahler, Greg Mann, and Michael Park. Changes ------- mpark's comments. Bugs: MESOS-5271 https://issues.apache.org/jira/browse/MESOS-5271 Repository: mesos Description ------- Added deprecation support to Flag name. Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 4d37c4afdcf4c3d6d511dd8a27916332b086afa7 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc Diff: https://reviews.apache.org/r/46669/diff/ Testing ------- make check Thanks, Vinod Kone --===============8829509817698581006==--