From reviews-return-32600-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 29 06:47:22 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E0CCC19D71 for ; Fri, 29 Apr 2016 06:47:22 +0000 (UTC) Received: (qmail 66112 invoked by uid 500); 29 Apr 2016 06:47:22 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 66084 invoked by uid 500); 29 Apr 2016 06:47:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 66061 invoked by uid 99); 29 Apr 2016 06:47:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Apr 2016 06:47:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6F8B62A3AAD; Fri, 29 Apr 2016 06:47:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4013998938536664074==" MIME-Version: 1.0 Subject: Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature. From: Vinod Kone To: Ben Mahler , Michael Park , Greg Mann Cc: Vinod Kone , mesos Date: Fri, 29 Apr 2016 06:47:17 -0000 Message-ID: <20160429064717.26230.31151@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46815/ X-Sender: Vinod Kone References: <20160429032928.26196.46997@reviews.apache.org> In-Reply-To: <20160429032928.26196.46997@reviews.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============4013998938536664074== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46815/ ----------------------------------------------------------- (Updated April 29, 2016, 6:47 a.m.) Review request for mesos, Ben Mahler, Greg Mann, and Michael Park. Changes ------- add a new dependency. Bugs: MESOS-5271 https://issues.apache.org/jira/browse/MESOS-5271 Repository: mesos Description ------- Updated mesos to work with new `flags.load()` signature. Diffs (updated) ----- src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf src/examples/dynamic_reservation_framework.cpp 4ad5f4b846052ec9a2067a5ce21fb017f681debf src/examples/load_generator_framework.cpp b22a09e1749d4b523addacad99858d7b6bde3403 src/examples/long_lived_framework.cpp 1740d7cb747d179d06e75153aa334b29e9cdf3c0 src/examples/no_executor_framework.cpp f578edfd99f3b7adf19cf06eab20696532c7b67d src/examples/persistent_volume_framework.cpp b4faa0ee25dc3a72c17ef2b0640a3695423ef79a src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 src/launcher/http_command_executor.cpp 0b4136c040ec9cf585c0d38f8471495a855cd640 src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 src/slave/container_loggers/logrotate.cpp 7d36c052ff7a180b45ca265fb7ff4c6900d98d64 src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 src/usage/main.cpp 7777731acb69900b6fc2bb7bd19cccd78aafb0cc Diff: https://reviews.apache.org/r/46815/diff/ Testing ------- make check Thanks, Vinod Kone --===============4013998938536664074==--