From reviews-return-32585-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 29 03:25:40 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 17EA3198C7 for ; Fri, 29 Apr 2016 03:25:40 +0000 (UTC) Received: (qmail 86324 invoked by uid 500); 29 Apr 2016 03:25:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86291 invoked by uid 500); 29 Apr 2016 03:25:39 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86273 invoked by uid 99); 29 Apr 2016 03:25:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Apr 2016 03:25:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 74A4E2B385E; Fri, 29 Apr 2016 03:25:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0716701321683120858==" MIME-Version: 1.0 Subject: Review Request 46814: Refactored FlagsBase::load(). From: Vinod Kone To: Ben Mahler , Michael Park , Greg Mann Cc: Vinod Kone , mesos Date: Fri, 29 Apr 2016 03:25:34 -0000 Message-ID: <20160429032534.26196.41845@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46814/ X-Sender: Vinod Kone Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============0716701321683120858== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46814/ ----------------------------------------------------------- Review request for mesos, Ben Mahler, Greg Mann, and Michael Park. Bugs: MESOS-5271 https://issues.apache.org/jira/browse/MESOS-5271 Repository: mesos Description ------- Made this function more readable. The error strings are still kept the same as the previous code. Diffs ----- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 Diff: https://reviews.apache.org/r/46814/diff/ Testing ------- make check Thanks, Vinod Kone --===============0716701321683120858==--