-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/#review130675
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (line 91)
<https://reviews.apache.org/r/46669/#comment194515>

    s/effectiveName/effective_name/



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 951 - 955)
<https://reviews.apache.org/r/46669/#comment194514>

    return warning as a string/Warning instead of directly logging here.


- Vinod Kone


On April 26, 2016, 1:08 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46669/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 1:08 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
>     https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added deprecation support to Flag name.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46669/diff/
> 
> 
> Testing
> -------
> 
> Tested manually by running ./bin/mesos-master.sh --authenticate
> 
> The one caveat is that the deprecation warning might be printed before logging the library is initialized (e.g., master/main.cpp calls flags.load() before logging::initialize(flags)).
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>