From reviews-return-32538-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 28 18:35:36 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CE00218095 for ; Thu, 28 Apr 2016 18:35:36 +0000 (UTC) Received: (qmail 48149 invoked by uid 500); 28 Apr 2016 18:35:36 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 48122 invoked by uid 500); 28 Apr 2016 18:35:36 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 48109 invoked by uid 99); 28 Apr 2016 18:35:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2016 18:35:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5ED012B3CCE; Thu, 28 Apr 2016 18:35:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7832564870455915716==" MIME-Version: 1.0 Subject: Re: Review Request 46723: Send error message to the framework when it is not connected. From: Vinod Kone To: Vinod Kone Cc: Anand Mazumdar , mesos Date: Thu, 28 Apr 2016 18:35:31 -0000 Message-ID: <20160428183531.26196.7594@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46723/ X-Sender: Vinod Kone X-ReviewBoard-ShipIt: 1 References: <20160427233714.26196.66522@reviews.apache.org> In-Reply-To: <20160427233714.26196.66522@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============7832564870455915716== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46723/#review130967 ----------------------------------------------------------- Ship it! Ship It! - Vinod Kone On April 27, 2016, 11:37 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46723/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 11:37 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5181 > https://issues.apache.org/jira/browse/MESOS-5181 > > > Repository: mesos > > > Description > ------- > > This change adds logic to send the framework an error message > if the master receives a call from the framework after it has > disconnected/when the master notices a framework disconnection. > Since driver based frameworks don't receive heartbeats from the > master. There is no way for them to detect this unless a new > master is detected that eventually triggers re-registration. > > > Diffs > ----- > > src/master/master.cpp ff41da3d077b65b44277e1bbae88c61b7bb88a3d > > Diff: https://reviews.apache.org/r/46723/diff/ > > > Testing > ------- > > Added test in r46724 > > > Thanks, > > Anand Mazumdar > > --===============7832564870455915716==--