From reviews-return-32311-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 26 00:54:19 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 907FD19C54 for ; Tue, 26 Apr 2016 00:54:19 +0000 (UTC) Received: (qmail 20314 invoked by uid 500); 26 Apr 2016 00:54:19 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 20285 invoked by uid 500); 26 Apr 2016 00:54:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 20271 invoked by uid 99); 26 Apr 2016 00:54:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 00:54:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 51B532B1FCA; Tue, 26 Apr 2016 00:54:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4164329591202173263==" MIME-Version: 1.0 Subject: Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string. From: Vinod Kone To: Ben Mahler Cc: Benjamin Bannier , Vinod Kone , mesos Date: Tue, 26 Apr 2016 00:54:14 -0000 Message-ID: <20160426005414.26230.7584@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46620/ X-Sender: Vinod Kone References: <20160425144827.26230.27509@reviews.apache.org> In-Reply-To: <20160425144827.26230.27509@reviews.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============4164329591202173263== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 25, 2016, 2:48 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, line 45 > > > > > > If this was `const` it would be much easier to reason how this works with all the usage sites. const makes it harder to use the Flag (which contains the Name) in a map; because the assignment operator is deleted. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review130422 ----------------------------------------------------------- On April 25, 2016, 5:43 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46620/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 5:43 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-5271 > https://issues.apache.org/jira/browse/MESOS-5271 > > > Repository: mesos > > > Description > ------- > > This sets up the stage to add metadata to the name (e.g., deprecated). > This will be used to add deprecation support subsequently. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 > > Diff: https://reviews.apache.org/r/46620/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > > --===============4164329591202173263==--