From reviews-return-32067-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 22 20:46:16 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 82B3F19BBE for ; Fri, 22 Apr 2016 20:46:16 +0000 (UTC) Received: (qmail 80115 invoked by uid 500); 22 Apr 2016 20:46:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 80091 invoked by uid 500); 22 Apr 2016 20:46:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 80076 invoked by uid 99); 22 Apr 2016 20:46:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Apr 2016 20:46:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B88912B25F4; Fri, 22 Apr 2016 20:46:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1222764196669263359==" MIME-Version: 1.0 Subject: Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf. From: Vinod Kone To: Vinod Kone , Zhiwei Chen Cc: Benjamin Bannier , mesos Date: Fri, 22 Apr 2016 20:46:11 -0000 Message-ID: <20160422204611.8130.98579@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46314/ In-Reply-To: <20160422055821.8129.66361@reviews.apache.org> X-Sender: Vinod Kone X-ReviewBoard-ShipIt: 1 References: <20160422055821.8129.66361@reviews.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/3rdparty/protobuf-2.6.1.patch X-ReviewBoard-ShipIt-Only: 1 Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============1222764196669263359== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/#review130171 ----------------------------------------------------------- Ship it! Ship It! - Vinod Kone On April 22, 2016, 5:58 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46314/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 5:58 a.m.) > > > Review request for mesos, Zhiwei Chen and Vinod Kone. > > > Bugs: MESOS-4678 > https://issues.apache.org/jira/browse/MESOS-4678 > > > Repository: mesos > > > Description > ------- > > This adds the upstream patch `717f807` which is contained in > `protobuf-3.0.0-alpha-1`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt 7b3621d24a05a3b3b860e3b8c13a1531208e5e26 > 3rdparty/libprocess/3rdparty/Makefile.am 895663b0095cfb1e682da90606c34a96ad036834 > 3rdparty/libprocess/3rdparty/protobuf-2.6.1.patch PRE-CREATION > > Diff: https://reviews.apache.org/r/46314/diff/ > > > Testing > ------- > > Building with GCC6 w/o this patch leads to a hard failure to a comparison between a signed and unsigned types; with this patch the build succeeds. > > > Thanks, > > Benjamin Bannier > > --===============1222764196669263359==--